Site Links
Home
Features
Documentation
Pricing & Order
Members Area
Support Options
Who's Online
4 registered (GEN™, packlite, Thelockman, 1 invisible), 36 Guests and 20 Spiders online.
Key: Admin, Global Mod, Mod
Featured Member
Registered: 02/15/08
Posts: 18
Top Posters (30 Days)
Ruben Rocha 95
Rick 85
Mark S 74
Gizmo 49
Thelockman 49
driv 35
Sirdude 32
ntdoc 28
packlite 27
AllenAyres 25
Latest Photos
bear test
Beach Barbie-Q
Sunset
Accept the challenge!
Trees
Topic Options
Rate This Topic
#217752 - 10/10/08 08:27 AM [FIXED in 7.4] [7.3.1] There are still htmlentities ...
smallufo Offline
enthusiast

Registered: 06/05/06
Posts: 205
Loc: Taiwan
Code:
ubbthreads $ grep -e htmlent * -R
admin/viewboard.php:$feed_name = htmlentities($feed_name);
admin/viewboard.php:            $line = htmlentities($line);
admin/viewboard.php:            $line = htmlentities($line);
admin/viewboard.php:            $line = htmlentities($line);
admin/rss.php:  $name = htmlentities($name);
admin/external_island.php:$html_string = nl2br(htmlentities($html_string));
admin/showuser.php:$usertitle = htmlentities($usertitle);
admin/editcustomisland.php:     $line = htmlentities($line);
admin/editcustomisland.php:$portal_name = htmlentities($portal_name);
libs/smarty/plugins/modifier.escape.php:            return htmlentities($string, ENT_QUOTES);
libs/ubbthreads.inc.php:                $title = htmlentities($title);
scripts/getmediumpic.inc.php:   $link = htmlentities(preg_replace("/</","&lt;",$link));



These should be replaced with htmlspecialchars
_________________________

English is not my native language.
I try my best to express my thought precisely.
I hope you understand what I mean.
If any misunderstanding results from culture gaps , I apologize first.

Top
#217753 - 10/10/08 08:41 AM Re: [7.3.1] There are still htmlentities ... [Re: smallufo]
Rick Administrator Offline

*****

Registered: 06/04/06
Posts: 7998
Loc: Aberdeen, WA
These are all fixed for 7.4. In some places you may still see htmlentities, but we still have to use those when the language isn't set to UTF-8, so there is some code in there under that condition.
_________________________
UBB.threads™ Developer
My Personal Website · StogieSmokers.com

Top


Shout Box

Today's Birthdays
theregit
Recent Topics
7.4.2 UNREAD
by Thelockman
57 minutes 41 seconds ago
7.4.1 show/hide category bug
by Seattlebrian
Today at 11:56 AM
7.4.2 Discussion
by Rick
Today at 10:21 AM
UBBCentral now running 7.4.2
by Rick
Today at 10:21 AM
New members don't get access and are not displayed in the config panel
by Yomar
Yesterday at 03:32 AM
Forum Stats
4298 Members
33 Forums
30693 Topics
156040 Posts

Max Online: 978 @ 06/24/07 08:19 PM