You are not logged in. [Log In] UBB.threads PHP Forum Software Community » Forums » UBB.threads 7 Discussion » Bug Reports
      » Fixed Bugs » [FIXED for 7.5] URL link detection
Register User    Portal Page     Forum List        Calendar     Active Topics     Search     FAQ
Site Links
Home
Features
Documentation
Pricing & Order
Members Area
Support Options
UBBDev.com
UBBWiki.com
Who's Online
2 registered (Dunny, Ruben), 48 Guests and 14 Spiders online.
Key: Admin, Global Mod, Mod
Featured Member
Registered: 06/05/06
Posts: 709
Top Posters (30 Days)
Ruben 50
DennyP 24
Gizmo 24
Dunny 15
SteveS 13
AllenAyres 12
dbremer 10
SD 10
drkknght00 9
driv 8
Latest Photos
OK Corral Shoot Out
Testing
Basildon Train Station
Basildon Town Centre looking from the rounderbout
Basildon Town Square
Page 1 of 2 1 2 >
Topic Options
#221875 - 02/02/09 12:27 PM [FIXED for 7.5] URL link detection
MichaelM Offline
newbie 		Registered: 08/30/07
Posts: 37
Hello,

When posting the following link

http://i447.photobucket.com/albums/qq191/yvonne112/Cocos%20pics/DSC01095.jpg

the post does not recognize it as a link in the message.

Is this a bug?

Thanks,
Mike
Top
Express Hosting
Express Hosting "We are the official hosting company of UBB.threads. Ask us about our free migration services to migrate your UBB.threads installation."
#221890 - 02/02/09 01:36 PM Re: URL link detection [Re: MichaelM]
Gizmo Offline

Registered: 06/05/06
Posts: 14995
Loc: Portland, OR; USA
I think the regex is choking on the % sign
_________________________
Forums: UGN Security & VNC Web Design & Development
UBB.Threads: UBB.Wiki, My UBBSkins, UBB.Sitemaps
Longtime UBB Supporter, UBB Beta Tester & Resident Post-A-Holic.
UBB Modifications, Styling, Coding Services, Disaster Recovery, and more!
Top
#221928 - 02/02/09 08:08 PM Re: URL link detection [Re: Gizmo]
JAISP Offline
old hand 		Registered: 02/10/07
Posts: 1144
%20 is a space to a Linux server running Apache.

Best never to use direct spaces in anything web related but rather an underscore for spaces.

"web_space" rather then "web space".
Top
#221929 - 02/02/09 11:36 PM Re: URL link detection [Re: JAISP]
SD Offline
Registered: 04/19/07
Posts: 4056
Loc: SoCal, USA
that's a good 'practice' Thelockman-UNiT, but you'll never get members to adhere to that rule all the time..

the regex (bbcode.inc.php) could (should) be updated to handle it... :2c:

oh and %20 is space for ANY url.. it's nothing to do with apache and linux.. %20 loves IIS / doze too and is just how url encoding works.. %20 (hex 20) is decimal 32, which is ascii number for space .. smile
_________________________

Threads tutorials . Threads & Wordpress experts . UBB resume

If I you, click this link as to why
Top
#221931 - 02/02/09 11:42 PM Re: URL link detection [Re: SD]
gliderdad Offline
Registered: 06/08/06
Posts: 1466
Loc: NY
My members complained about it to. They couldn't grasp that the should name folder in photobucket without a space and use an underscore.

Told them if they want it to work, best change that folder name :X
Top
#221933 - 02/02/09 11:52 PM Re: URL link detection [Re: gliderdad]
SD Offline
Registered: 04/19/07
Posts: 4056
Loc: SoCal, USA
yah, i personally NEVER use spaces in URL's and typically use underscores _ instead... it's 'natural' to me, but assuming it's natural for everyone else, doesn't work laugh
_________________________

Threads tutorials . Threads & Wordpress experts . UBB resume

If I you, click this link as to why
Top
#221934 - 02/03/09 12:04 AM Re: URL link detection [Re: SD]
gliderdad Offline
Registered: 06/08/06
Posts: 1466
Loc: NY
LOL, yes you are right. Assumptions are the mother of all....you know what! All we can do is steer them in the right direction.
Top
#221935 - 02/03/09 12:24 AM Re: URL link detection [Re: gliderdad]
MichaelM Offline
newbie 		Registered: 08/30/07
Posts: 37
I never uses spaces in URLs. But that isn't the case for the members of our message board. Even still if %20 is a legitimate sequence in a URL then I would think UBB Threads should support it.
Top
#221936 - 02/03/09 01:15 AM Re: URL link detection [Re: MichaelM]
SD Offline
Registered: 04/19/07
Posts: 4056
Loc: SoCal, USA
yeppers smile
_________________________

Threads tutorials . Threads & Wordpress experts . UBB resume

If I you, click this link as to why
Top
#221937 - 02/03/09 03:09 AM Re: URL link detection [Re: SD]
gliderdad Offline
Registered: 06/08/06
Posts: 1466
Loc: NY
It use to work that way prior to 7.4.1 I think
Top
#221945 - 02/03/09 11:19 AM Re: URL link detection [Re: gliderdad]
Rick Offline
Post-a-holic 		Registered: 06/04/06
Posts: 10164
Loc: Aberdeen, WA
I have this fixed for 7.5.
Top
#222278 - 02/12/09 06:41 AM Re: URL link detection [Re: Rick]
Kayjey Offline

journeyman 		Registered: 12/24/03
Posts: 94
Loc: Belgium
Can someone give me the fix code?
_________________________
www.straydesign.com
Top
#222326 - 02/13/09 05:33 AM Re: URL link detection [Re: Kayjey]
Kayjey Offline

journeyman 		Registered: 12/24/03
Posts: 94
Loc: Belgium
Okay... I actually didn't know anything about regex (they're REALLY Chinese for me), but after going through some documentation, I would presume the fix to be like this:

In "libs" / "bbcode.inc.php" change:

Code:


$body = preg_replace('#(\n|\r|\]|^|\s|\(|<)([a-zA-Z0-9]+?)://(([a-zA-Z0-9\.\-\_\?=\#/&]|&)+)(>|<|\n|\r|$|,(\s|$)|\?(\s|$)|\)|\s|\.(\s|$))#ie', '\'$1\'.$this->handle_url(\'$2://$3\').\'$5\'', $body);


into
Code:


$body = preg_replace('#(\n|\r|\]|^|\s|\(|<)([a-zA-Z0-9]+?)://(([a-zA-Z0-9\.\-\_\?=\#/&]|&|[\+\%])+)(>|<|\n|\r|$|,(\s|$)|\?(\s|$)|\)|\s|\.(\s|$))#ie', '\'$1\'.$this->handle_url(\'$2://$3\').\'$5\'', $body);


and

Code:


$body = preg_replace('#(\n|\r|\]|^|\s|<|\()www\.(([a-zA-Z0-9\.\-\_\?&/\#=]|&)+)($|>|\)|,(\s|$)|\?(\s|$)|\)(\s|$)|\s|\.(\s|$))#ie', '\'$1\'.$this->handle_url(\'http://www.$2\',\'www.$2\').\'$4\'', $body);


into

Code:


$body = preg_replace('#(\n|\r|\]|^|\s|<|\()www\.(([a-zA-Z0-9\.\-\_\?&/\#=]|&|[\+\%])+)($|>|\)|,(\s|$)|\?(\s|$)|\)(\s|$)|\s|\.(\s|$))#ie', '\'$1\'.$this->handle_url(\'http://www.$2\',\'www.$2\').\'$4\'', $body);


basically adding "|[\+\%]" after the "amp;" to include plus and percent signs.
_________________________
www.straydesign.com
Top
#222423 - 02/15/09 07:21 AM Re: URL link detection [Re: Kayjey]
Yarp™ Offline
Registered: 08/30/06
Posts: 1513
Loc: Breda, NL
Originally Posted By: Kayjey
Okay... I actually didn't know anything about regex (they're REALLY Chinese for me), but after going through some documentation, I would presume the fix to be like this:


If you ever want to learn chinese, RegexBuddy™ could be your new best friend!
_________________________
Top
#222428 - 02/15/09 12:44 PM Re: URL link detection [Re: Yarp™]
SD Offline
Registered: 04/19/07
Posts: 4056
Loc: SoCal, USA
RegexBuddy
_________________________

Threads tutorials . Threads & Wordpress experts . UBB resume

If I you, click this link as to why
Top
Page 1 of 2 1 2 >



Moderator:  AllenAyres, Harold, Ian, Ron M 
Shout Box

Today's Birthdays
No Birthdays
Recent Topics
Temporary Password email not being received
by
05/24/12 10:02 PM
Ability to "like" individual posts (not Facebook "likes)
by doug
05/23/12 09:03 AM
Island Permissions
by ThreadsUser
05/22/12 03:03 PM
streaming video
by prkrgrp
05/20/12 07:02 PM
New Posts Corrupted? Can someone help?
by PianoWorld
05/19/12 09:41 AM
Forum Stats
10492 Members
36 Forums
33842 Topics
181709 Posts

Max Online: 978 @ 06/24/07 11:19 PM
Random Image
Board Rules · Mark all read
Contact Us · UBBCentral · Top