Previous Thread
Next Thread
Print Thread
Hop To
Joined: Mar 2004
Posts: 7
K
stranger
stranger
K Offline
Joined: Mar 2004
Posts: 7
Edit Message Grace Period:

Edited notice will not appear until this many minutes elapse. Set to zero to disable.


Ours is set to zero, but it still appears when changing other user posts. This used to work, but now that we have 6.6.1 it does not.

We modified the code to make it work ... not interested in continuing our maintenance, as the features being added do not seem to have that much of an impact with us.


ALSO - Flood Protection does not work properly.

If you fail to put in a subject, and you get a msg that you did not enter a subject, and then you fix the subject and press Add New Topic, it tells you that you have to wait 30 seconds ... that does not seem right either. It should only stop you if you have SUCCESSFULLY posted a message within 30 seconds.

Joined: Jun 2006
Posts: 346
R
enthusiast
enthusiast
R Offline
Joined: Jun 2006
Posts: 346
Quote
Please do not report bugs in non-current versions. If you have found a bug in a previous version, please upgrade to see if the bug has already been fixed. Please be sure to include the URL to your board in your bug report.

Anonymous
Unregistered
Anonymous
Unregistered
confirmed both on 6.7, although I don't think the first one is a bug

Joined: Jun 2006
Posts: 346
R
enthusiast
enthusiast
R Offline
Joined: Jun 2006
Posts: 346
On the first one, I believe that it will show it for Admins and Mods regardless of the settings.

The second one, I'm guessing the flood check is only detecting the POST operation before validating the form contains valid data.

Joined: Mar 2004
Posts: 7
K
stranger
stranger
K Offline
Joined: Mar 2004
Posts: 7
>> Please do not report bugs in non-current versions. If you have found a bug in a previous version, please upgrade to see if the bug has already been fixed.

There is a list which clearly indicates what changes and fixes are in each version - this is not mentioned. There is no need to go through the hassle of upgrading only to find the fix was not there.

> On the first one, I believe that it will show it for Admins and Mods regardless of the settings.

This is not the case of what the option says it will do. If a moderator corrects the spelling or grammer error of another moderator, it makes the company look bad ... you don't want this to show. It will also make one moderator look like the other does not know what he is talking about, etc. To keep the posts professional (as we need in our case, as we are running a company board), we cannot have "EDITED BY" ever appear. This worked just fine in previous versions until we upgraded to 6.6 -

> The second one, I'm guessing the flood check is only detecting the POST operation before validating the form contains valid data.

Yes, this IS the case ... however, there is a timer variable which holds the time of the alst post ... and just compare it when the post occurs AFTER validation. Checking before validation is not proper.

1. Post
2. Check validation
3. Check Previous Timer Value
4. Write to file
5. Store timer value in variable

It seems the system is setup as:

1. Post
2. Check Previous Timer Value
3. Check validation
4. Write to file
5. Store timer value in variable

Just moving the logic will correct the issue.


In terms of the first option - we need the ability to remain to simply not have that message appear, ever, especially if a moderator changes another moderator.

Joined: Jun 2006
Posts: 346
R
enthusiast
enthusiast
R Offline
Joined: Jun 2006
Posts: 346
Charles will say what I quoted about the bug report being on 6.6.1.

The edit by message will be labeled NOTABUG because in 6.7 ubb_edit_post.cgi

Quote
# If you wish to prevent admin / mod edits of
# messages from having the edited message,
# comment out the following line:
$appender = $string;

Joined: Mar 2004
Posts: 7
K
stranger
stranger
K Offline
Joined: Mar 2004
Posts: 7
> # If you wish to prevent admin / mod edits of
# messages from having the edited message,
# comment out the following line:
$appender = $string;


Please tell me this is a joke .... commenting out source code to make an option work properly, or as labeled on the screen.

It used to work before we upgraded. Now it no longer works .... so commenting out the source code every version is the answer? This is ridiculous.

The system was set previously not to do this - it started happening immediately after we upgraded. The feature on the screen clearly says "Edited notice will not appear until this many minutes elapse. Set to zero to disable."

It is set to ZERO and it is not disabled. If it has been modified because of another request, it affects us ... so just have another checkbox after it that says "Disable for moderators and administrators too" - or whatever.

Joined: Jun 2006
Posts: 346
R
enthusiast
enthusiast
R Offline
Joined: Jun 2006
Posts: 346
If you feel that change is in order, then I would post a feature suggestion. The feature is working as designed in the software.

Joined: Mar 2004
Posts: 7
K
stranger
stranger
K Offline
Joined: Mar 2004
Posts: 7
>The feature is working as designed in the software.

Yes, the feature is working and designed as the programmer programmed it. :rolleyes:

Joined: Jul 2006
Posts: 2,143
Pooh-Bah
Pooh-Bah
Joined: Jul 2006
Posts: 2,143
That's right, it is. <img src="https://www.ubbcentral.com/boards/images/graemlins/smile.gif" alt="" />

The original functionality of the edited message not appearing at the bottom of messages when admins performed the edit was viewed as a bug, and fixed. I intentionally left a hook in the code so that it would be easy to revert back to the old behavior, as we knew that the minority of users prefered the old behavior (including a few on the beta testing team). We did not want to make this a control panel toggle.


This thread for sale. Click here! [Linked Image from navaho.infopop.cc]
Anonymous
Unregistered
Anonymous
Unregistered
Personally, I'd prefer it as a control panel toggle.

Joined: Jun 2006
Posts: 16,292
Likes: 116
UBB.threads Developer
UBB.threads Developer
Joined: Jun 2006
Posts: 16,292
Likes: 116
Yeh, CP toggles would be sweet for most of the one liners <img src="https://www.ubbcentral.com/boards/images/graemlins/wink.gif" alt="" /> ...


I am a Web Development Contractor, I do not work for UBBCentral. I have provided free User to User Support since the beginning of these support forums.
Do you need Forum Install or Upgrade Services?
Forums: A Gardeners Forum, Scouters World
UBB.threads: UBBWiki, UBB Styles, UBB.Sitemaps
Longtime Supporter & Resident Post-A-Holic
VNC Web Services: Code Modifications, Upgrades, Styling, Coding Services, Disaster Recovery, and more!
Joined: Mar 2004
Posts: 7
K
stranger
stranger
K Offline
Joined: Mar 2004
Posts: 7
Yes, the CP toggles would be best for everyone. Switches are always best.

Joined: Jul 2006
Posts: 2,143
Pooh-Bah
Pooh-Bah
Joined: Jul 2006
Posts: 2,143
Generally, yes. However, in this case, the feature operates as designed, intentionally. It is not our general belief that there should be a control panel preference for it. The same goes for the 16+ other hidden controls in the code. <img src="https://www.ubbcentral.com/boards/images/graemlins/smile.gif" alt="" />

The floodcheck issue while making a new topic has been resolved in 6.7.1. The floodcheck will occur after any topic subject validation. I'll post back here with a revision number once the fix has been checked in.


This thread for sale. Click here! [Linked Image from navaho.infopop.cc]
Joined: Jun 2006
Posts: 16,292
Likes: 116
UBB.threads Developer
UBB.threads Developer
Joined: Jun 2006
Posts: 16,292
Likes: 116
How about a miscelanious section (yeh i spelled it wrong, so what) with the heading "you forefit support if you activate these, their here for general customization needs"... Then you can have it and not have to worry abou them <img src="https://www.ubbcentral.com/boards/images/graemlins/wink.gif" alt="" /> ..


I am a Web Development Contractor, I do not work for UBBCentral. I have provided free User to User Support since the beginning of these support forums.
Do you need Forum Install or Upgrade Services?
Forums: A Gardeners Forum, Scouters World
UBB.threads: UBBWiki, UBB Styles, UBB.Sitemaps
Longtime Supporter & Resident Post-A-Holic
VNC Web Services: Code Modifications, Upgrades, Styling, Coding Services, Disaster Recovery, and more!
Joined: Jun 2006
Posts: 16,292
Likes: 116
UBB.threads Developer
UBB.threads Developer
Joined: Jun 2006
Posts: 16,292
Likes: 116
I'd report it as a bug that my board still shows the edited by notice with it commented out, but theid tell me to unmod my board <img src="https://www.ubbcentral.com/boards/images/graemlins/wink.gif" alt="" /> ...


I am a Web Development Contractor, I do not work for UBBCentral. I have provided free User to User Support since the beginning of these support forums.
Do you need Forum Install or Upgrade Services?
Forums: A Gardeners Forum, Scouters World
UBB.threads: UBBWiki, UBB Styles, UBB.Sitemaps
Longtime Supporter & Resident Post-A-Holic
VNC Web Services: Code Modifications, Upgrades, Styling, Coding Services, Disaster Recovery, and more!
Joined: Jul 2006
Posts: 2,143
Pooh-Bah
Pooh-Bah
Joined: Jul 2006
Posts: 2,143
For record keeping purposes, this fix landed in rv210.2.6.


This thread for sale. Click here! [Linked Image from navaho.infopop.cc]

Link Copied to Clipboard
ShoutChat
Comment Guidelines: Do post respectful and insightful comments. Don't flame, hate, spam.
Recent Topics
spam issues
by ECNet - 03/19/2024 11:45 PM
Looking for a forum
by azr - 03/15/2024 11:26 PM
Editing Links in Post
by Outdoorking - 03/15/2024 9:31 AM
Question on barkrowler and the like
by Mors - 02/29/2024 6:51 PM
Member Permissions Help
by domspeak - 02/27/2024 6:31 PM
Who's Online Now
1 members (Havenofsobriety), 522 guests, and 99 robots.
Key: Admin, Global Mod, Mod
Random Gallery Image
Latest Gallery Images
Los Angeles
Los Angeles
by isaac, August 6
3D Creations
3D Creations
by JAISP, December 30
Artistic structures
Artistic structures
by isaac, August 29
Stones
Stones
by isaac, August 19
Powered by UBB.threads™ PHP Forum Software 8.0.0
(Preview build 20230217)