Previous Thread
Next Thread
Print Thread
Hop To
email footer issues v7.7.3
#263461 02/06/2020 5:04 PM
Joined: Dec 2003
Posts: 6,089
Likes: 14
Ruben Offline OP
OP Offline
Joined: Dec 2003
Posts: 6,089
Likes: 14
I tested this whith a virgin install.
But anyway I was checking for gdpr compliance, etc and I noticed a issue in the footer.
Which seems to be in the language files mailer.php
In particular the top 4 keys in the raw zip file:
Code
$ubbt_lang['EMAIL_HEADER_TEXT'] = "{$config['COMMUNITY_TITLE']}<br>----------------------------------<br>";
$ubbt_lang['EMAIL_HEADER_HTML'] = "{$config['COMMUNITY_TITLE']}";
$ubbt_lang['EMAIL_FOOTER_TEXT'] = "This email was auto-generated. Please do not reply.<br><br>Manage your email preferences:<br>{$config['FULL_URL']}/ubbthreads.php?ubb=editdisplay<br><br>Update your forum profile:<br>{$config['FULL_URL']}/ubbthreads.php?ubb=editbasic<br><br>";
$ubbt_lang['EMAIL_FOOTER_HTML'] = "This email was sent by <a href=\"{$config['HOMEPAGE_URL']}\">{$config['HOMEPAGE_TITLE']}</a>.<br>To control which emails we send you, <a href=\"{$config['FULL_URL']}/ubbthreads.php?ubb=editdisplay\">update your email preferences</a>.";

But after a net new install I get in the language file in the cp:
Ca't seem to copy paste the key with the text so will manually enter it
Code
EMAIL_HEADER_TEXT <br>----------------------------------<br>
EMAIL_HEADER_HTML 
EMAIL_FOOTER_TEXT  This email was auto-generated. Please do not reply.<br><br>Manage your email preferences:<br>/ubbthreads.php?ubb=editdisplay<br><br>Update your forum profile:<br>/ubbthreads.php?ubb=editbasic<br><br>
EMAIL_FOOTER_HTML This email was sent by <a href=""></a>.<br>To control which emails we send you, <a href="/ubbthreads.php?ubb=editdisplay">update your email preferences</a>.
So what happens when you send a email from the site what is displayed in the footer is first no community title and the link to change your preferences is a relative url which will not redirect the user.
Attached two images of the email

Attached Files Screenshot (31).pngScreenshot (32).png
Last edited by Ruben; 02/06/2020 5:16 PM. Reason: fixed post

Blue Man Group
There is no such thing as stupid questions. Just stupid answers
Re: email footer issues v7.7.3
Ruben #263462 02/06/2020 5:08 PM
Joined: Dec 2003
Posts: 6,089
Likes: 14
Ruben Offline OP
OP Offline
Joined: Dec 2003
Posts: 6,089
Likes: 14
For some reason the attachment did not show the link which is just /ubbthreads.php
Let me try another attachment.

Attached Files Screenshot (33).png

Blue Man Group
There is no such thing as stupid questions. Just stupid answers
Re: email footer issues v7.7.3
Ruben #263463 02/06/2020 5:13 PM
Joined: Apr 2004
Posts: 1,651
Likes: 33
UBB.threads Developer
Offline
UBB.threads Developer
Joined: Apr 2004
Posts: 1,651
Likes: 33
Your homepage url should always be an absolute url.

Homepage URL is the primary URL of your homepage.


Current developer of UBB.threads PHP Forum Software // 7.7.4 released!
isaac @ id242.com // my forum @ CelicaHobby.com
Re: email footer issues v7.7.3
Ruben #263464 02/06/2020 5:19 PM
Joined: Apr 2004
Posts: 1,651
Likes: 33
UBB.threads Developer
Offline
UBB.threads Developer
Joined: Apr 2004
Posts: 1,651
Likes: 33
See attached images.

edit: sorry, im not at a desktop this morning, so these are the best screenshots im able to provide with the tools available to me at the moment

Attached Files Screenshot_20200206-131737.pngScreenshot_20200206-131801.png
Last edited by isaac; 02/06/2020 5:20 PM.

Current developer of UBB.threads PHP Forum Software // 7.7.4 released!
isaac @ id242.com // my forum @ CelicaHobby.com
Re: email footer issues v7.7.3
Ruben #263465 02/06/2020 5:24 PM
Joined: Dec 2003
Posts: 6,089
Likes: 14
Ruben Offline OP
OP Offline
Joined: Dec 2003
Posts: 6,089
Likes: 14
okay what I am trying to say is when a email is sent to a member.
The footer is missing the community title.
Then the 2nd line in the footer has a url to take the customer to their preferences.
The problem is the link only has
/ubbthreads.php?ubb=editdisplay
Without a ttl.

So you can't in the email click on the link to take you to a site to change you options.
I tested it on three 7.7.3 sites as well as a net new install.

The only way to make it work is to edit the language file and add the leading part of the URL


Blue Man Group
There is no such thing as stupid questions. Just stupid answers
Re: email footer issues v7.7.3
Ruben #263466 02/06/2020 5:28 PM
Joined: Dec 2003
Posts: 6,089
Likes: 14
Ruben Offline OP
OP Offline
Joined: Dec 2003
Posts: 6,089
Likes: 14
Send email is turned off here but the email on follow lists here work correctly.
But then again you are using v7.7.4 here


Blue Man Group
There is no such thing as stupid questions. Just stupid answers
Re: email footer issues v7.7.3
Ruben #263467 02/06/2020 5:33 PM
Joined: Apr 2004
Posts: 1,651
Likes: 33
UBB.threads Developer
Offline
UBB.threads Developer
Joined: Apr 2004
Posts: 1,651
Likes: 33
for the urls, my screenshots show nothing unique from 773 and 774 beyond the fields being rearranged and placed within their relevant pages and grouped accordingly.


Current developer of UBB.threads PHP Forum Software // 7.7.4 released!
isaac @ id242.com // my forum @ CelicaHobby.com
Re: email footer issues v7.7.3
Ruben #263468 02/06/2020 5:33 PM
Joined: Dec 2003
Posts: 6,089
Likes: 14
Ruben Offline OP
OP Offline
Joined: Dec 2003
Posts: 6,089
Likes: 14
For thrills and giggles what does this site have in the language file mailer.php for
EMAIL_HEADER_TEXT
EMAIL_HEADER_HTML
EMAIL_FOOTER_TEXT
EMAIL_FOOTER_HTML


Blue Man Group
There is no such thing as stupid questions. Just stupid answers
Re: email footer issues v7.7.3
Ruben #263469 02/06/2020 5:41 PM
Joined: Apr 2004
Posts: 1,651
Likes: 33
UBB.threads Developer
Offline
UBB.threads Developer
Joined: Apr 2004
Posts: 1,651
Likes: 33
TEXT: is the first half of the email source. this is displayed if the email client is set to TEXT ONLY, or cannot display HTML. this method is not common, but is still provided.

HTML: is the second part of the email source. this is displayed when the email client can display html in emails. this is the modern way if displaying email and is most common.

if you open an email to view its true source (not the web page source), you'll see that there are two versions of the email. first is TEXT, followed by HTML

the email client usually displays the HTML version if it can.

You may remember way back prior to 2005, in early forum software, there would be a user option to manually select "email type: text only. html only." In modern email clients, the client is usually who chooses this.

Furthering the case of using only plain text emails, either the recipient would have turned HTML off for incoming emails, or someone at their company or email host has. There are some companies that have strict no-HTML policies for security and privacy reasons.


Current developer of UBB.threads PHP Forum Software // 7.7.4 released!
isaac @ id242.com // my forum @ CelicaHobby.com
Re: email footer issues v7.7.3
Ruben #263470 02/06/2020 5:45 PM
Joined: Apr 2004
Posts: 1,651
Likes: 33
UBB.threads Developer
Offline
UBB.threads Developer
Joined: Apr 2004
Posts: 1,651
Likes: 33

Last edited by isaac; 02/06/2020 5:52 PM.

Current developer of UBB.threads PHP Forum Software // 7.7.4 released!
isaac @ id242.com // my forum @ CelicaHobby.com
Re: email footer issues v7.7.3
Ruben #263471 02/06/2020 5:48 PM
Joined: Dec 2003
Posts: 6,089
Likes: 14
Ruben Offline OP
OP Offline
Joined: Dec 2003
Posts: 6,089
Likes: 14
Okay back to the language file
Mailer.php
EMAIL_FOOTER the entry is
Code
This email was sent by <a href=""></a>.<br>To control which emails we send you, <a href="/ubbthreads.php?ubb=editdisplay">update your email preferences</a>.

How is someone supposed to navigate to a site from a email if that is all it has in the footer.
The link in the footer has
/ubbthreads.php?ubb=editdisplay
Thats it no http and or domain name.


Blue Man Group
There is no such thing as stupid questions. Just stupid answers
Re: email footer issues v7.7.3
Ruben #263472 02/06/2020 5:51 PM
Joined: Apr 2004
Posts: 1,651
Likes: 33
UBB.threads Developer
Offline
UBB.threads Developer
Joined: Apr 2004
Posts: 1,651
Likes: 33
see my first reply with its screenshots, and confirm that you are using absolute urls correctly.


Current developer of UBB.threads PHP Forum Software // 7.7.4 released!
isaac @ id242.com // my forum @ CelicaHobby.com
Re: email footer issues v7.7.3
Ruben #263473 02/06/2020 5:52 PM
Joined: Dec 2003
Posts: 6,089
Likes: 14
Ruben Offline OP
OP Offline
Joined: Dec 2003
Posts: 6,089
Likes: 14
Sorry that was EMAIL_FOOTER_HTML


Blue Man Group
There is no such thing as stupid questions. Just stupid answers
Re: email footer issues v7.7.3
Ruben #263474 02/06/2020 5:58 PM
Joined: Apr 2004
Posts: 1,651
Likes: 33
UBB.threads Developer
Offline
UBB.threads Developer
Joined: Apr 2004
Posts: 1,651
Likes: 33
Originally Posted by Ruben
Sorry that was EMAIL_FOOTER_HTML

<a> links are HTML, so are <br>

i guess what your asking for is that the TXT version be displayed without the <br> and instead us /r and /n

as for the <a> in the TXT version, they should not be there because they are HTML and thats not whats being requested.

maybe im missing something thst youre trying to point out, since.i dont have a desktop computer today, and am trying to assist you through a mobile phone 🤔


Current developer of UBB.threads PHP Forum Software // 7.7.4 released!
isaac @ id242.com // my forum @ CelicaHobby.com
Re: email footer issues v7.7.3
Ruben #263475 02/06/2020 6:03 PM
Joined: Apr 2004
Posts: 1,651
Likes: 33
UBB.threads Developer
Offline
UBB.threads Developer
Joined: Apr 2004
Posts: 1,651
Likes: 33
Maybe the SMARTY Template Engine is killing the inputs within the language files.

I believe this may be the point youre trying to make, that i havent been getting until just now...



screenshot of your OP after scrolling the code blocks aligned:

[Linked Image]

Last edited by isaac; 02/06/2020 6:04 PM.

Current developer of UBB.threads PHP Forum Software // 7.7.4 released!
isaac @ id242.com // my forum @ CelicaHobby.com
Re: email footer issues v7.7.3
Ruben #263476 02/06/2020 6:11 PM
Joined: Dec 2003
Posts: 6,089
Likes: 14
Ruben Offline OP
OP Offline
Joined: Dec 2003
Posts: 6,089
Likes: 14
I think you are on the right track now.
How would I test the SMARTY Template Engine
I can wait till you are on a desktop


Blue Man Group
There is no such thing as stupid questions. Just stupid answers
Re: email footer issues v7.7.3
Ruben #263477 02/06/2020 6:16 PM
Joined: Apr 2004
Posts: 1,651
Likes: 33
UBB.threads Developer
Offline
UBB.threads Developer
Joined: Apr 2004
Posts: 1,651
Likes: 33
Originally Posted by Ruben
I think you are on the right track now.
How would I test the SMARTY Template Engine

The issue may be that smarty tags are being used within the language files, and processed (or ignored). Where what should be use instead, are %%SUBSTITUTIONS%%.

If this is the case, then its a long standing issue within the language files, and definitely will be fixed on the next ubbt release.

But i'd like to research this first to confirm it. Your documentation above is helpful in doing that.


Originally Posted by Ruben
I can wait till you are on a desktop

thank you 😁


Current developer of UBB.threads PHP Forum Software // 7.7.4 released!
isaac @ id242.com // my forum @ CelicaHobby.com
Re: email footer issues v7.7.3
Ruben #263479 02/08/2020 3:37 PM
Joined: Apr 2004
Posts: 1,651
Likes: 33
UBB.threads Developer
Offline
UBB.threads Developer
Joined: Apr 2004
Posts: 1,651
Likes: 33
As a followup, this is being worked on now complete, and will be is completely fixed for UBB.threads 7.7.4 release.

A lot of moving around of code to make these corrections, so the template editor works as expected.

Ruben, thanks again for your patience in demonstrating what exactly the issue is. Thank you 😁

Last edited by isaac; 02/10/2020 8:42 AM. Reason: complete!

Current developer of UBB.threads PHP Forum Software // 7.7.4 released!
isaac @ id242.com // my forum @ CelicaHobby.com
Re: email footer issues v7.7.3
Ruben #263482 02/11/2020 2:15 PM
Joined: Dec 2003
Posts: 6,089
Likes: 14
Ruben Offline OP
OP Offline
Joined: Dec 2003
Posts: 6,089
Likes: 14
Great. It seems like it was the placeholder that referenced using the $config values that made it bark.
In the language files there were like 8 items as I recall that I found.
I fat fingered them in for now.

Thanks again.


Blue Man Group
There is no such thing as stupid questions. Just stupid answers
1 member likes this: isaac
Re: email footer issues v7.7.3
Ruben #263483 02/11/2020 2:24 PM
Joined: Apr 2004
Posts: 1,651
Likes: 33
UBB.threads Developer
Offline
UBB.threads Developer
Joined: Apr 2004
Posts: 1,651
Likes: 33
Doing a grep, I came across 34 of them. It took an entire day to rewrite the language string configuration substitutions in to the script files. Apparently, adding {$config[]} strings directly within the language files has been a thing since before I came on board with the coding in 2014. Though, prior to 2010, Ian and Rick really did a good job of keeping those things under control.

Fixed for UBB.threads 7.7.4 laugh


Current developer of UBB.threads PHP Forum Software // 7.7.4 released!
isaac @ id242.com // my forum @ CelicaHobby.com
Re: email footer issues v7.7.3
Ruben #263484 02/11/2020 2:34 PM
Joined: Dec 2003
Posts: 6,089
Likes: 14
Ruben Offline OP
OP Offline
Joined: Dec 2003
Posts: 6,089
Likes: 14
I recall over the years that it was hit or miss on them some sites worked some did not and some versions worked and some did not.
But I fixated on just the email footer
I am happy to see another bug squashed.

Great support.Guy


Blue Man Group
There is no such thing as stupid questions. Just stupid answers

Link Copied to Clipboard
ShoutChat Box
Comment Guidelines: Do post respectful and insightful comments. Don't flame, hate, spam.
Recent Topics
SFS Login Detection Issue [NotABug]
by Ruben - 03/29/2020 1:16 PM
possible bug?
by Morgan - 03/29/2020 5:18 AM
CSS sprites
by Ruben - 03/28/2020 2:29 PM
Who's Online Now
1 members (1 invisible), 119 guests, and 42 robots.
Key: Admin, Global Mod, Mod
Random Gallery Image
Latest Gallery Images
3D Creations
3D Creations
by JAISP, December 30
Artistic structures
Artistic structures
by isaac, August 29
Stones
Stones
by isaac, August 19
Amusing Terain Scenics
Amusing Terain Scenics
by isaac, August 19
Sky places
Sky places
by isaac, August 19
Powered by UBB.threads™ PHP Forum Software 7.7.4