UBBCentral
Posted By: Baldeagle [FIXED for 7.7.4] Strange Merge Issue - 08/16/2019 7:37 PM
I've updated our forum to 7.7.3, which is, I believe, the current version. This was posted on our moderator's forum. A bug? Or something wrong with our setup?
Quote
Any time a thread is moved, the link in the original thread directing the reader to the new location still points to THIS thread. It makes no difference what thread is moved or where it's moved to, the reader always ends up in the 2005 thread. I'm having to send every errant thread starter a PM explaining what happened to their thread and where it is now. I'm also deleting the post with the errant link since it points no where.
Posted By: Ruben Re: Strange Merge Issue - 08/17/2019 7:58 PM
Not knowing what "This thread" is or the new thread location. It is hard to tell.
Whenever you move a thread you have options to leave a pointer or not and for how many days.

Or could it be that selecting the post from say a side island is the problem.
I say that because they are cached and for a few moments may still point to a old location.
Till the cache gets rebuilt.

actual post urls may help a bit with troublshooting the issues.
Visiting your site as a guest I don't see a forum with 2005 in the name.
Posted By: Baldeagle Re: Strange Merge Issue - 08/17/2019 8:17 PM
This THIS refers to this thread: https://www.stovebolt.com/ubbthreads/ubbthreads.php/topics/192022.html

No matter what thread is being moved, the pointer always points to this thread, almost like it's hard-coded.

I just created a thread in our welcome center forum, then moved it to general truck talk Here's the original post: https://www.stovebolt.com/ubbthread...mber/1322264/gonew/1/testing.html#UNREAD
The link points to here: https://www.stovebolt.com/ubbthreads/ubbthreads.php/topics/192061.html, not to the new location.

This is the actual moved post in its new location: https://www.stovebolt.com/ubbthreads/ubbthreads.php/topics/1322263/testing.html#Post1322263

As you can see, it's not always the same thread, but the redirect link doesn't point to the actual new location.
Posted By: Ruben Re: Strange Merge Issue - 08/17/2019 8:50 PM
Looks to me like a broken item.
The referenced move post id does not even have the post.
192061 post is not the same post where it should be Post1322263
Wonder if it has to do with using se friendly and html posting setting.
Posted By: Baldeagle Re: Strange Merge Issue - 08/17/2019 9:00 PM
I know, but this happens with every moved post.
Posted By: Ruben Re: Strange Merge Issue - 08/17/2019 9:11 PM
Give isaac a chance to reply.
Gizmo is here now and reading same maybe he has some insight.
I don;t have the issue but I don't use the html feature.
That is the only reason I suspect the item
Posted By: Baldeagle Re: Strange Merge Issue - 08/20/2019 12:35 AM
Isaac? Any ideas?
Posted By: isaac Re: Strange Merge Issue - 08/20/2019 9:16 AM
In an attempt to duplicate your issue and resolve it, how are you moving your threads?

1) Inline moving from the postlist?
This will leave no pointer, so you're probably not doing it this way.

2) Editing the post OP and choosing "Move/Merge This Post and Any Replies"
On the following screen which options are you selecting?
a/ "Should a PM be sent to this thread starter?"
b/ "Reason for moving?"

3) From the showflat page (the post OP and its replies page), by choosing the "Tools" drop-down menu and selecting "Move/Merge Thread"
On the following screen which options are you selecting?
a/ "Leave a pointer at the old location?"
b/ "Delete pointer in XX days."
c/ "Should a PM be sent to this thread starter?"
d/ "Reason for moving?"
Posted By: isaac Re: Strange Merge Issue - 08/20/2019 10:29 AM
Baldeagle, thank you for reporting this.

I was able to reproduce the error, and correct it.

IN /scripts/showflat.inc.php
FIND (around line 859):
Code
$results[$i]['POST_BODY'] = "<a href=\"" . make_ubb_url("ubb={$mode}&Number=$NewNumber", "", false) . "\">{$ubbt_lang['POINTER']}</a>{$results[$i]['POST_BODY']}";


REPLACE WITH:
Code
$results[$i]['POST_BODY'] = "<a href=\"" . make_ubb_url("ubb={$mode}&topic=$NewNumber", "", false) . "\">{$ubbt_lang['POINTER']}</a>{$results[$i]['POST_BODY']}";


NOTES:
The bug was introduced in UBB.threads 7.7.2 (Released July 2nd, 2019), and also exists in UBB.threads 7.7.3 (Released July 28th, 2019). It will be fixed for UBB.threads 7.7.4.

This bug occurs when a entire thread is being moved and a pointer is left in its old location. From the list in my previous post, that would be, "3" with "a".

This fix reverts a code change I had incorrectly made in 7.7.2. With this correction, all moved post pointers should now function correctly again.


Again, thanks to Baldeagle for being the first to report this bug!
Posted By: Baldeagle Re: [FIXED for 7.7.4] Strange Merge Issue - 08/20/2019 7:36 PM
Oh wow. Thanks. I'll edit the page.

I can confirm that this code change fixes the problem. Thanks, Isaac. No idea how you found that, but then that's why you get paid the big bucks, right? thumbsup
© 2019 UBB.threads PHP Forum Software Community