|
Joined: Jun 2006
Posts: 136
member
|
member
Joined: Jun 2006
Posts: 136 |
opening XML output from my forums brings up the following error in Firefox: it seems firefox thinks that XML declarations should be done on the very first line of the file. the XML output being produced by UBB is inserting a blank line at the beginning of the file. firefox rendering of XML files also complains about & chars in some sections.
Last edited by Rick; 10/08/2006 6:06 PM.
|
|
|
|
Joined: Jun 2006
Posts: 956
Old Hand
|
Old Hand
Joined: Jun 2006
Posts: 956 |
This was reportet somewhere here. There is a blank line in the template that need to be removed.
|
|
|
|
Joined: Jun 2006
Posts: 9,242 Likes: 1
Former Developer
|
Former Developer
Joined: Jun 2006
Posts: 9,242 Likes: 1 |
|
|
|
|
Joined: Jun 2006
Posts: 136
member
|
member
Joined: Jun 2006
Posts: 136 |
i've fixed the problem with the blank line. now firefox is complaining about ampersands (&) in various places: XML Parsing Error: not well-formed Location: http://www.jakchat.com/forums/cache/rss12.xmlLine Number 5, Column 48: <title>Gentlemen, Revolutionaries, Scholars & Bules</title> -------------------------------------------------------------^ unfortunately, many of my forum names use "&" in theor names!
|
|
|
|
Joined: Jun 2006
Posts: 16,301 Likes: 116
|
Joined: Jun 2006
Posts: 16,301 Likes: 116 |
yeh, i think we need to start using htmlspecialchars()
|
|
|
|
Joined: Jun 2006
Posts: 9,242 Likes: 1
Former Developer
|
Former Developer
Joined: Jun 2006
Posts: 9,242 Likes: 1 |
Hmm, we are using htmlspecialchars for both the subject and body. I think the problem is we aren't using it for the feed title itself. It looks like the fix will be on line 2589 of libs/ubbthreads.inc.php
Currently, that reads:
$smarty->assign("feed_name",$feed_name);
when it should be:
$smarty->assign("feed_name",htmlspecialchars($feed_name));
|
|
|
|
Joined: Jun 2006
Posts: 16,301 Likes: 116
|
Joined: Jun 2006
Posts: 16,301 Likes: 116 |
I know we aren't on forum descriptions or category/forum names (which would be nice for validity and all)
|
|
|
|
Joined: Jun 2006
Posts: 136
member
|
member
Joined: Jun 2006
Posts: 136 |
Currently, that reads:
$smarty->assign("feed_name",$feed_name);
when it should be:
$smarty->assign("feed_name",htmlspecialchars($feed_name)); this has fixed the title problems. however, now i notice that the posts being generated in the RSS feed seem to be random. they are not following any recognizable logical order. i had wanted the last 10 or so newest posts to be generated into the feed, instead, it gets the last post, and then seems to select old posts at "random".
|
|
|
1 members (Ruben),
1,277
guests, and
207
robots. |
Key:
Admin,
Global Mod,
Mod
|
|
|
|