UBB.threads PHP Forum Software Community Forums UBB.threads Bug Reports Fixed Bugs [Fixed 7.3][7.2.2] New user e-mail notification setting does not work

there's a setting in admin's profile whether or not to receive e-mails when a new user has registered. Both the code in /scripts/adduser.inc.php and /scripts/verifyemail.inc.php does not work (well, it's the same piece of code )

The problem is in this line:

PHP Code

if (!$config['NEW_USER_MODERATION'] && !$notify_newuser) { 

Since $notify_newuser is always 0 or 1, it always has a value.

I fixed it locally by moving this check into the query instead of in the code. Did the same for the admin e-mail check that's there.

I'm gonna testrun the code now and place it here for anyone looking to fix this.

Update: analysed why it goes wrong wrong, but the bug is there!

that code is fine.

you realize that !0 --> true and !1 --> bummer, right ?

This my replacement code.

Update: Removed it. Was no good.

Whether that code is fine or not, I don't know for sure, it was my primary suspect, I do know the setting is ignored because I gets loads of new user notifications while the setting for me is off

update:
okay, did a codetest, you are right. But somehow somewhere else on the road it goes wrong, because the bug itselve is definitely there.

ok, so your config must be set to 1 then. so !1 && !0 is killing that if and forcing an unwanted email.

i see, at 2nd blush there looks to be a small 'buglet'

hehe, I only just noticed it because I changed a bit in the board name (we have a tagline that I moved to the "Powered by" language string. So my mail blocks weren't working anymore.

Well, the checks done in the code can be done in the query

except for the $config check. that turns it off, regardless if admins like emails.

so to me i see the $config check must be true, then any admin who wants emails gets them. right ?

Well, the whole block should not be run according to the config setting. It should not be checked inside the loop.

hrm...

there are 2 settings 'EMAIL_VERIFICATION' and 'NEW_USER_MODERATION'

1st one is whether the new user needs to verify their email. 2nd one is whether or not the new users get placed in a queue to be accepted or declined.

as i see it.

and currently the question asked of the admin in their preferences is if they want to be notified on any new user registration. there is really noting about whether an approval is required.

so if you want to take it to the extreme, the admin gets emails if he likes them and those emails are either : 'hey a new user signed up' or 'hey a new user signed up and needs you to approve the poor bashtid'

no ?

Basicly, that's a yes

As long as I don't get those mails

Fixed 7.3