[FIXED in 7.4] [7.3.1] There are still htmlentities ...

Print Thread

Hop To

#217752 10/10/2008 11:27 AM

Joined: Jun 2006

Posts: 215

Taiwan

smallufo

enthusiast

smallufo

enthusiast

Joined: Jun 2006

Posts: 215

Taiwan

Code

ubbthreads $ grep -e htmlent * -R
admin/viewboard.php:$feed_name = htmlentities($feed_name);
admin/viewboard.php:            $line = htmlentities($line);
admin/viewboard.php:            $line = htmlentities($line);
admin/viewboard.php:            $line = htmlentities($line);
admin/rss.php:  $name = htmlentities($name);
admin/external_island.php:$html_string = nl2br(htmlentities($html_string));
admin/showuser.php:$usertitle = htmlentities($usertitle);
admin/editcustomisland.php:     $line = htmlentities($line);
admin/editcustomisland.php:$portal_name = htmlentities($portal_name);
libs/smarty/plugins/modifier.escape.php:            return htmlentities($string, ENT_QUOTES);
libs/ubbthreads.inc.php:                $title = htmlentities($title);
scripts/getmediumpic.inc.php:   $link = htmlentities(preg_replace("/</","&lt;",$link));

These should be replaced with htmlspecialchars

English is not my native language. I try my best to express my thought precisely. I hope you understand what I mean. If any misunderstanding results from culture gaps, I apologize first.

Re: [7.3.1] There are still htmlentities ... smallufo #217753 10/10/2008 11:41 AM
Joined: Jun 2006 Posts: 9,242 Likes: 1 Aberdeen, WA R Rick Former Developer
Rick Former Developer R Joined: Jun 2006 Posts: 9,242 Likes: 1 Aberdeen, WA	These are all fixed for 7.4. In some places you may still see htmlentities, but we still have to use those when the language isn't set to UTF-8, so there is some code in there under that condition.

Link Copied to Clipboard

ShoutChat

Comment Guidelines: Do post respectful and insightful comments. Don't flame, hate, spam.

UBB.threads PHP Forum Software Community Forums UBB.threads Bug Reports Fixed Bugs [FIXED in 7.4] [7.3.1] There are still htmlentities ...