Previous Thread
Next Thread
Print Thread
Hop To
Joined: Jun 2006
Posts: 693
Addict
Addict
Joined: Jun 2006
Posts: 693
I'm getting errors in my error log now that I've upgraded to 7.5.7. They read:

Sun, Dec 16 2012 04:44:11 -0500
Script: E:\forums\scripts\postlist.inc.php - Line: 511
select t1.TOPIC_ID,t1.POST_ID,t2.USER_DISPLAY_NAME,t1.TOPIC_CREATED_TIME,t1.TOPIC_LAST_REPLY_TIME,t1.TOPIC_SUBJECT,
t1.TOPIC_STATUS,t1.TOPIC_IS_APPROVED,t1.TOPIC_ICON,t1.TOPIC_VIEWS,t1.TOPIC_REPLIES,t1.TOPIC_TOTAL_RATES,
t1.TOPIC_RATING,t3.USER_NAME_COLOR,t2.USER_MEMBERSHIP_LEVEL,t1.USER_ID,t1.TOPIC_IS_STICKY,t1.TOPIC_LAST_POSTER_ID,
t1.TOPIC_LAST_POSTER_NAME,t1.TOPIC_LAST_POST_ID,t1.TOPIC_IS_EVENT,t1.TOPIC_HAS_FILE,t1.TOPIC_HAS_POLL,t1.TOPIC_POSTER_NAME,t1.TOPIC_THUMBNAIL,t4.POST_BODY,t3.USER_GROUP_IMAGES
from ubbt7_TOPICS as t1
left join ubbt7_USERS as t2 on t1.USER_ID = t2.USER_ID
left join ubbt7_USER_PROFILE as t3 on t1.USER_ID = t3.USER_ID
left join ubbt7_POSTS as t4 on t1.POST_ID = t4.POST_ID
where t1.FORUM_ID = 175
and t1.TOPIC_IS_STICKY = '0'

AND t1.TOPIC_IS_APPROVED = '1'
ORDER BY t1.TOPIC_LAST_REPLY_TIME desc
LIMIT -20, 11
- You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '-20, 11' at line 14


My reading of the SQL syntax finds:
"LIMIT takes one or two numeric arguments, which must both be nonnegative integer constants (except when using prepared statements)."

So the -20 is negative. Is this considered a "prepared statement"?


Lisa Shea, owner, BellaOnline.com
BellaOnline Website
BellaOnline Forums - UBB since Apr 2002 - 58,000 members / 850,000 posts
Joined: Apr 2007
Posts: 3,940
Likes: 1
SD Offline
Former Developer
Former Developer
Joined: Apr 2007
Posts: 3,940
Likes: 1
bug has been in there since a long time..

postlist.inc.php

find:

PHP Code

	// If $page isn't set then it defaults to 1
	if (empty($page)) {
		$page = $_SESSION['currentpage'];
		if (!$page) {
			$page = 1;
		}
		if ($page < 1) $page = 1;
	}
 

change to:

PHP Code

	// If $page isn't set then it defaults to 1
	if (empty($page)) {
		$page = $_SESSION['currentpage'];
		if (!$page) {
			$page = 1;
		}
	}
	if ($page < 1) $page = 1;
 

it was always too trusting of the $page variable, if it was supplied in the URL.

this doesn't allow it to go 0 or negative.

the url that caused your error had a page of -1 in it.. ( default topics per is set to 10, so (-1 -1 ) * 10 --> 20... and a limit of 10+1 --> 11

smile

i will put this into the release... Brooks can notify when it is in the official .zip download smile

Joined: Jun 2006
Posts: 693
Addict
Addict
Joined: Jun 2006
Posts: 693
OK thanks I've just made the change in all of my forums.

For those on 7.5.7 the line number is 115 where this is found.


Lisa Shea, owner, BellaOnline.com
BellaOnline Website
BellaOnline Forums - UBB since Apr 2002 - 58,000 members / 850,000 posts
Joined: Sep 2009
Posts: 36
newbie
newbie
Joined: Sep 2009
Posts: 36
I'm also getting an error after 7.5.7 but it means I can't re-edit longer posts with formatting after the initial post.

Getting this:
[deleted my pathname here]/ubbthreads/scripts/modifypost.inc.php
Line#: 365
SQL Error: Incorrect key file for table '[deleted my pathname here] ubbt_POSTS.MYI'; try to repair it
SQL Error #: 126

Joined: Dec 2003
Posts: 6,632
Likes: 85
Joined: Dec 2003
Posts: 6,632
Likes: 85
Originally Posted by Mark J.Cairns
I'm also getting an error after 7.5.7 but it means I can't re-edit longer posts with formatting after the initial post.

Getting this:
[deleted my pathname here]/ubbthreads/scripts/modifypost.inc.php
Line#: 365
SQL Error: Incorrect key file for table '[deleted my pathname here] ubbt_POSTS.MYI'; try to repair it
SQL Error #: 126
You cross posted but read my two replies at:
https://www.ubbcentral.com/forums/u...e_Board_security_key_keeps_ch#Post252388
Sounds to be a corrupted Mysql table.


Blue Man Group
There is no such thing as stupid questions. Just stupid answers

Link Copied to Clipboard
ShoutChat
Comment Guidelines: Do post respectful and insightful comments. Don't flame, hate, spam.
Recent Topics
"Recent Posts" box
by SenecaFlyer - 12/13/2024 12:06 PM
Sticky posts and global announcements
by Larry Miller - 12/08/2024 2:30 PM
Profile avatar storage settings
by SenecaFlyer - 12/05/2024 1:24 PM
Not allowing attachment over 2m
by ehill - 12/03/2024 3:16 PM
New Admin Here
by SenecaFlyer - 12/02/2024 4:14 PM
Who's Online Now
3 members (Ruben, SenecaFlyer, 1 invisible), 1,719 guests, and 157 robots.
Key: Admin, Global Mod, Mod
Random Gallery Image
Latest Gallery Images
Ride safe!
Ride safe!
by Morgan, December 7
Los Angeles
Los Angeles
by isaac, August 6
3D Creations
3D Creations
by JAISP, December 30
Artistic structures
Artistic structures
by isaac, August 29
Powered by UBB.threads™ PHP Forum Software 8.0.1
(Snapshot build 20240918)