Previous Thread
Next Thread
Print Thread
Hop To
Joined: Mar 2007
Posts: 307
Likes: 3
E
Enthusiast
Enthusiast
E Offline
Joined: Mar 2007
Posts: 307
Likes: 3
Just noticed that the Custom Insert in the Gallery Forum Threads is appearing twice, after First and Second Post.

Example: https://www.electrical-contractor.net/forums/ubbthreads.php/galleries/195236/how-about-some-emt.html

Any ideas?

Bill

Joined: Jun 2006
Posts: 16,369
Likes: 126
UBB.threads Developer
UBB.threads Developer
Joined: Jun 2006
Posts: 16,369
Likes: 126
Has someone modified your templates/default/post_side.tpl or templates/default/post_top.tpl files? There should only be one instance of
Code
{if $smarty.section.post.iteration == 1}{$island_insert}{/if}

In either file (towards the bottom); do you have any second instance of {$island_insert} in either file?

Edit: We were able to reproduce this on UBBDev here; it appears to only affect Gallery Forums, this will be fixed in v7.7.4. Thank you for reporting smile

Last edited by Gizmo; 08/15/2019 5:34 PM.

I am a Web Development Contractor, I do not work for UBBCentral. I have provided free User to User Support since the beginning of these support forums.
Do you need Forum Install or Upgrade Services?
Forums: A Gardeners Forum, Scouters World
UBB.threads: UBBWiki, UBB Styles, UBB.Sitemaps
Longtime Supporter & Resident Post-A-Holic
VNC Web Services: Code Modifications, Upgrades, Styling, Coding Services, Disaster Recovery, and more!
Joined: Mar 2007
Posts: 307
Likes: 3
E
Enthusiast
Enthusiast
E Offline
Joined: Mar 2007
Posts: 307
Likes: 3
No, files are as they were when upgraded about 10 days ago.

Only 1 instance in either file.

BTW, it's only happening in the Gallery Forum threads as far as I can see.

Joined: Jun 2006
Posts: 16,369
Likes: 126
UBB.threads Developer
UBB.threads Developer
Joined: Jun 2006
Posts: 16,369
Likes: 126
Originally Posted by Gizmo
Edit: We were able to reproduce this on UBBDev here; it appears to only affect Gallery Forums, this will be fixed in v7.7.4. Thank you for reporting smile
Not sure if you caught my edit before your reply; this should be patched in the next release.


I am a Web Development Contractor, I do not work for UBBCentral. I have provided free User to User Support since the beginning of these support forums.
Do you need Forum Install or Upgrade Services?
Forums: A Gardeners Forum, Scouters World
UBB.threads: UBBWiki, UBB Styles, UBB.Sitemaps
Longtime Supporter & Resident Post-A-Holic
VNC Web Services: Code Modifications, Upgrades, Styling, Coding Services, Disaster Recovery, and more!
Joined: Apr 2004
Posts: 1,974
Likes: 154
UBB.threads Developer
UBB.threads Developer
Joined: Apr 2004
Posts: 1,974
Likes: 154
Originally Posted by Gizmo
Edit: We were able to reproduce this on UBBDev here; it appears to only affect Gallery Forums, this will be fixed in v7.7.4. Thank you for reporting smile

Thank you ECNet for reporting this.


current developer of UBB.threads php forum software
current release: UBB.threads 8.0.0 // wip: UBB.threads 8.0.1
isaac @ id242.com // my forum @ CelicaHobby.com
Joined: Mar 2007
Posts: 307
Likes: 3
E
Enthusiast
Enthusiast
E Offline
Joined: Mar 2007
Posts: 307
Likes: 3
For what it's worth, I can't totally guarantee it wasn't like that before upgrade, but I think I would have noticed.

Joined: Mar 2007
Posts: 307
Likes: 3
E
Enthusiast
Enthusiast
E Offline
Joined: Mar 2007
Posts: 307
Likes: 3
Originally Posted by isaac
Originally Posted by Gizmo
Edit: We were able to reproduce this on UBBDev here; it appears to only affect Gallery Forums, this will be fixed in v7.7.4. Thank you for reporting smile

Thank you ECNet for reporting this.
Okay than, scratch my last comment... smile

Joined: Apr 2004
Posts: 1,974
Likes: 154
UBB.threads Developer
UBB.threads Developer
Joined: Apr 2004
Posts: 1,974
Likes: 154
As you've pointed out, it looks as though this bug has existed for nearly a decade, but no one before you has reported it. Big thank you!


A simple fix for this is -

IN templates/default/post_side.tpl
AND templates/default/post_top.tpl
FIND TOWARDS THE BOTTOM:
Code
{if $smarty.section.post.iteration == 1}{$island_insert}{/if}

REPLACE WITH
Code
{if $smarty.section.post.iteration == 1 && $post_layout != "gallery"}{$island_insert}{/if}

NOTES:
The problem is that the special template for the gallery forums has its own $island_insert line which places the island right after the topic post. Then the gallery forum continues to generate replies using your forums default post layout. There isnt a need to call the $island_insert once again for gallery forums.

If the $island_insert is removed from the gallery post, then the $island_insert would not appear after the OP, but instead after first REPLY, which is not something we want.

This simple check should correct that.


current developer of UBB.threads php forum software
current release: UBB.threads 8.0.0 // wip: UBB.threads 8.0.1
isaac @ id242.com // my forum @ CelicaHobby.com
Joined: Mar 2007
Posts: 307
Likes: 3
E
Enthusiast
Enthusiast
E Offline
Joined: Mar 2007
Posts: 307
Likes: 3
Got it, Thanks!


Link Copied to Clipboard
ShoutChat
Comment Guidelines: Do post respectful and insightful comments. Don't flame, hate, spam.
Recent Topics
Profile avatar storage settings
by SenecaFlyer - 12/05/2024 1:24 PM
Not allowing attachment over 2m
by ehill - 12/03/2024 3:16 PM
New Admin Here
by SenecaFlyer - 12/02/2024 4:14 PM
Who's Online Now
1 members (Ruben), 1,809 guests, and 90 robots.
Key: Admin, Global Mod, Mod
Random Gallery Image
Latest Gallery Images
Los Angeles
Los Angeles
by isaac, August 6
3D Creations
3D Creations
by JAISP, December 30
Artistic structures
Artistic structures
by isaac, August 29
Stones
Stones
by isaac, August 19
Powered by UBB.threads™ PHP Forum Software 8.0.1
(Snapshot build 20240918)