Previous Thread
Next Thread
Print Thread
Hop To
[FIXED for 7.7.4] 2 Custom Inserts in Gallery Forum
#263077 08/15/2019 3:33 PM
Joined: Mar 2007
Posts: 244
ECNet Offline OP
Enthusiast
OP Offline
Enthusiast
Joined: Mar 2007
Posts: 244
Just noticed that the Custom Insert in the Gallery Forum Threads is appearing twice, after First and Second Post.

Example: https://www.electrical-contractor.net/forums/ubbthreads.php/galleries/195236/how-about-some-emt.html

Any ideas?

Bill

Re: [FIXED for 7.7.4] 2 Custom Inserts in Gallery Forum
ECNet #263080 08/15/2019 5:23 PM
Joined: Jun 2006
Posts: 15,868
Likes: 1
UBB.threads Developer
Offline
UBB.threads Developer
Joined: Jun 2006
Posts: 15,868
Likes: 1
Has someone modified your templates/default/post_side.tpl or templates/default/post_top.tpl files? There should only be one instance of
Code
{if $smarty.section.post.iteration == 1}{$island_insert}{/if}

In either file (towards the bottom); do you have any second instance of {$island_insert} in either file?

Edit: We were able to reproduce this on UBBDev here; it appears to only affect Gallery Forums, this will be fixed in v7.7.4. Thank you for reporting smile

Last edited by Gizmo; 08/15/2019 5:34 PM.

I am a Web Development Contractor, I do not work for UBBCentral. I have provided free User to User Support since the beginning of these support forums.
Do you need Forum Install or Upgrade Services?
Forums: A Gardeners Forum Scouters World
UBB.threads: UBBWiki, UBB Styles, UBB.Sitemaps
Longtime Supporter & Resident Post-A-Holic
VNC Web Services: Code Modifications, Upgrades, Styling, Coding Services, Disaster Recovery, and more!
Re: [FIXED for 7.7.4] 2 Custom Inserts in Gallery Forum
Gizmo #263082 08/15/2019 5:41 PM
Joined: Mar 2007
Posts: 244
ECNet Offline OP
Enthusiast
OP Offline
Enthusiast
Joined: Mar 2007
Posts: 244
No, files are as they were when upgraded about 10 days ago.

Only 1 instance in either file.

BTW, it's only happening in the Gallery Forum threads as far as I can see.

Re: [FIXED for 7.7.4] 2 Custom Inserts in Gallery Forum
Gizmo #263083 08/15/2019 5:45 PM
Joined: Jun 2006
Posts: 15,868
Likes: 1
UBB.threads Developer
Offline
UBB.threads Developer
Joined: Jun 2006
Posts: 15,868
Likes: 1
Originally Posted by Gizmo
Edit: We were able to reproduce this on UBBDev here; it appears to only affect Gallery Forums, this will be fixed in v7.7.4. Thank you for reporting smile
Not sure if you caught my edit before your reply; this should be patched in the next release.


I am a Web Development Contractor, I do not work for UBBCentral. I have provided free User to User Support since the beginning of these support forums.
Do you need Forum Install or Upgrade Services?
Forums: A Gardeners Forum Scouters World
UBB.threads: UBBWiki, UBB Styles, UBB.Sitemaps
Longtime Supporter & Resident Post-A-Holic
VNC Web Services: Code Modifications, Upgrades, Styling, Coding Services, Disaster Recovery, and more!
Re: [FIXED for 7.7.4] 2 Custom Inserts in Gallery Forum
Gizmo #263084 08/15/2019 5:46 PM
Joined: Apr 2004
Posts: 1,602
Likes: 8
UBB.threads Developer
Online Splat
UBB.threads Developer
Joined: Apr 2004
Posts: 1,602
Likes: 8
Originally Posted by Gizmo
Edit: We were able to reproduce this on UBBDev here; it appears to only affect Gallery Forums, this will be fixed in v7.7.4. Thank you for reporting smile

Thank you ECNet for reporting this.


Current developer of UBB.threads PHP Forum Software // 7.7.3 released!
isaac @ id242.com // my forum @ CelicaHobby.com
Re: [FIXED for 7.7.4] 2 Custom Inserts in Gallery Forum
ECNet #263085 08/15/2019 5:47 PM
Joined: Mar 2007
Posts: 244
ECNet Offline OP
Enthusiast
OP Offline
Enthusiast
Joined: Mar 2007
Posts: 244
For what it's worth, I can't totally guarantee it wasn't like that before upgrade, but I think I would have noticed.

Re: [FIXED for 7.7.4] 2 Custom Inserts in Gallery Forum
isaac #263086 08/15/2019 5:49 PM
Joined: Mar 2007
Posts: 244
ECNet Offline OP
Enthusiast
OP Offline
Enthusiast
Joined: Mar 2007
Posts: 244
Originally Posted by isaac
Originally Posted by Gizmo
Edit: We were able to reproduce this on UBBDev here; it appears to only affect Gallery Forums, this will be fixed in v7.7.4. Thank you for reporting smile

Thank you ECNet for reporting this.
Okay than, scratch my last comment... smile

Re: [FIXED for 7.7.4] 2 Custom Inserts in Gallery Forum
ECNet #263087 08/15/2019 8:45 PM
Joined: Apr 2004
Posts: 1,602
Likes: 8
UBB.threads Developer
Online Splat
UBB.threads Developer
Joined: Apr 2004
Posts: 1,602
Likes: 8
As you've pointed out, it looks as though this bug has existed for nearly a decade, but no one before you has reported it. Big thank you!


A simple fix for this is -

IN templates/default/post_side.tpl
AND templates/default/post_top.tpl
FIND TOWARDS THE BOTTOM:
Code
{if $smarty.section.post.iteration == 1}{$island_insert}{/if}

REPLACE WITH
Code
{if $smarty.section.post.iteration == 1 && $post_layout != "gallery"}{$island_insert}{/if}

NOTES:
The problem is that the special template for the gallery forums has its own $island_insert line which places the island right after the topic post. Then the gallery forum continues to generate replies using your forums default post layout. There isnt a need to call the $island_insert once again for gallery forums.

If the $island_insert is removed from the gallery post, then the $island_insert would not appear after the OP, but instead after first REPLY, which is not something we want.

This simple check should correct that.


Current developer of UBB.threads PHP Forum Software // 7.7.3 released!
isaac @ id242.com // my forum @ CelicaHobby.com
Re: [FIXED for 7.7.4] 2 Custom Inserts in Gallery Forum
isaac #263095 08/18/2019 10:13 AM
Joined: Mar 2007
Posts: 244
ECNet Offline OP
Enthusiast
OP Offline
Enthusiast
Joined: Mar 2007
Posts: 244
Got it, Thanks!


Link Copied to Clipboard
ShoutChat Box
Comment Guidelines: Do post respectful and insightful comments. Don't flame, hate, spam.
Recent Topics
AWS Lightsail platform
by jjjjj - 02/20/2020 7:27 AM
Users cant register after upgrade to Version 7
by Jim0421 - 02/13/2020 11:32 PM
Looking for best site firewall and CDN service
by Ruben - 02/11/2020 3:01 PM
custom island shows when logged in?
by Ruben - 02/11/2020 1:54 PM
email footer issues v7.7.3
by Ruben - 02/06/2020 4:04 PM
Who's Online Now
4 members (SD, JAISP, isaac, jjjjj), 85 guests, and 60 robots.
Key: Admin, Global Mod, Mod
Random Gallery Image
Latest Gallery Images
3D Creations
3D Creations
by JAISP, December 30
Artistic structures
Artistic structures
by isaac, August 29
Stones
Stones
by isaac, August 19
Amusing Terain Scenics
Amusing Terain Scenics
by isaac, August 19
Sky places
Sky places
by isaac, August 19
Powered by UBB.threads™ PHP Forum Software 7.7.4
(Snapshot build 20200220)