Previous Thread
Next Thread
Print Thread
Hop To
7.7.1 forgotten? //$reply = "off";
#262709 05/13/2019 7:25 PM
Joined: Apr 2019
Posts: 44
Newbie
OP Offline
Newbie
Joined: Apr 2019
Posts: 44
not bug

see scripts/showflat.inc.php
if ($topic_info['TOPIC_IS_STICKY'] == '2' && ($user['USER_MEMBERSHIP_LEVEL'] != "Administrator")) {
//$reply = "off";
}

but in scripts/addpost.inc.php

if ($issticky == "2" && ($user['USER_MEMBERSHIP_LEVEL'] != "Administrator")) {
$html->not_right($ubbt_lang['NO_R_ANNOUNCE']);
}

Last edited by BlackMale; 05/13/2019 7:28 PM.
Re: 7.7.1 forgotten? //$reply = "off";
BlackMale #262710 05/13/2019 10:02 PM
Joined: Jun 2006
Posts: 15,938
Likes: 27
UBB.threads Developer
Online Tapedshut
UBB.threads Developer
Joined: Jun 2006
Posts: 15,938
Likes: 27
Checks in the code are commonly commented out versus being removed for a variety of reasons, mainly testing. Just because code in a similar function isn't commented out doesn't mean similar code in other files should be live.


I am a Web Development Contractor, I do not work for UBBCentral. I have provided free User to User Support since the beginning of these support forums.
Do you need Forum Install or Upgrade Services?
Forums: A Gardeners Forum, I Find Rocks, Scouters World
UBB.threads: UBBWiki, UBB Styles, UBB.Sitemaps
Longtime Supporter & Resident Post-A-Holic
VNC Web Services: Code Modifications, Upgrades, Styling, Coding Services, Disaster Recovery, and more!
Re: 7.7.1 forgotten? //$reply = "off";
BlackMale #262711 05/13/2019 11:27 PM
Joined: Apr 2004
Posts: 1,697
Likes: 49
UBB.threads Developer
Offline
UBB.threads Developer
Joined: Apr 2004
Posts: 1,697
Likes: 49
The commented line has been that way since February 2009, with the release of UBB.threads 7.5.0.
https://www.ubbcentral.com/forums/ubbthreads.php/topics/221187/version-7-5-released-february-24-2009

Quote
[changed] It is now possible to reply to global announcements as long as the user has the ability to reply to regular topics. Locking the announcement will make it so it cannot be replied to.

The code is working as intend.

Please only provide bug reports for actual bugs. Bug reports for results of the code.

Multiple people have worked on the code over the past 20 years -- each with their own programming styles. Since the release of UBB.threads 7.6.0, many of those programming styles have been rewritten/reformatted to follow a single expected format.

Reporting issues about code layout or code-remarked items is not a bug.


Current developer of UBB.threads PHP Forum Software // 7.7.4 released!
isaac @ id242.com // my forum @ CelicaHobby.com

Link Copied to Clipboard
ShoutChat Box
Comment Guidelines: Do post respectful and insightful comments. Don't flame, hate, spam.
Recent Topics
[NOTABUG] Report Post bug..
by Morgan - 07/05/2020 1:48 PM
Trial Subscription question.
by Ruben - 07/03/2020 2:34 PM
Unread posts no longer tracked per user...
by KirkW - 06/16/2020 12:21 AM
Max Image file size upload
by jjjjj - 06/10/2020 10:25 PM
Error on Inert into POSTS
by jjjjj - 06/07/2020 8:09 PM
Who's Online Now
5 members (Gizmo, Ruben, Morgan, infernus86, JAISP), 91 guests, and 31 robots.
Key: Admin, Global Mod, Mod
Random Gallery Image
Latest Gallery Images
3D Creations
3D Creations
by JAISP, December 30
Artistic structures
Artistic structures
by isaac, August 29
Stones
Stones
by isaac, August 19
Amusing Terain Scenics
Amusing Terain Scenics
by isaac, August 19
Sky places
Sky places
by isaac, August 19
Powered by UBB.threads™ PHP Forum Software 7.7.4