Previous Thread
Next Thread
Print Thread
Hop To
7.7.1 forgotten? //$reply = "off"; #262709 05/13/2019 7:25 PM
Joined: Apr 2019
Posts: 45
BlackMale Offline OP
Newbie
OP Offline
Newbie
Joined: Apr 2019
Posts: 45
not bug

see scripts/showflat.inc.php
if ($topic_info['TOPIC_IS_STICKY'] == '2' && ($user['USER_MEMBERSHIP_LEVEL'] != "Administrator")) {
//$reply = "off";
}

but in scripts/addpost.inc.php

if ($issticky == "2" && ($user['USER_MEMBERSHIP_LEVEL'] != "Administrator")) {
$html->not_right($ubbt_lang['NO_R_ANNOUNCE']);
}

Last edited by BlackMale; 05/13/2019 7:28 PM.
Express Hosting
Re: 7.7.1 forgotten? //$reply = "off"; [Re: BlackMale] #262710 05/13/2019 10:02 PM
Joined: Jun 2006
Posts: 15,838
Gizmo Offline
UBB.threads Developer
Offline
UBB.threads Developer
Joined: Jun 2006
Posts: 15,838
Checks in the code are commonly commented out versus being removed for a variety of reasons, mainly testing. Just because code in a similar function isn't commented out doesn't mean similar code in other files should be live.


I am a Web Development Contractor, I do not work for UBBCentral. I have provided free User to User Support since the beginning of these support forums.
Need to Upgrade?
Forums: A Gardeners Forum Scouters World
UBB.threads: UBBWiki, UBB Styles, UBB.Sitemaps
Longtime Supporter & Resident Post-A-Holic
VNC Web Services: Code Modifications, Upgrades, Styling, Coding Services, Disaster Recovery, and more!
Re: 7.7.1 forgotten? //$reply = "off"; [Re: BlackMale] #262711 05/13/2019 11:27 PM
Joined: Apr 2004
Posts: 1,457
isaac Online Splat
UBB.threads Developer
Online Splat
UBB.threads Developer
Joined: Apr 2004
Posts: 1,457
The commented line has been that way since February 2009, with the release of UBB.threads 7.5.0.
https://www.ubbcentral.com/forums/ubbthreads.php/topics/221187/version-7-5-released-february-24-2009

Quote
[changed] It is now possible to reply to global announcements as long as the user has the ability to reply to regular topics. Locking the announcement will make it so it cannot be replied to.


The code is working as intend.

Please only provide bug reports for actual bugs. Bug reports for results of the code.

Multiple people have worked on the code over the past 20 years -- each with their own programming styles. Since the release of UBB.threads 7.6.0, many of those programming styles have been rewritten/reformatted to follow a single expected format.

Reporting issues about code layout or code-remarked items is not a bug.


isaac @ id242.com // my forum @ CelicaHobby.com
a current developer of UBB.threads php forum software // 7.7.2 released!

Additional Community Resources
UBB Developers
UBB Wiki
ShoutChat Box
Recent Topics
tools&information send email option v7.7.2
by Ruben - 07/23/2019 3:01 PM
Blue host and Mod_security issues
by Ruben - 07/21/2019 5:27 PM
Video Tags
by Outdoorking - 07/16/2019 2:39 AM
Two minor issues after upgrade
by Baldeagle - 07/13/2019 7:33 PM
Can the users have the option of hiding sub boards?
by tinker123 - 07/12/2019 9:55 PM
Who's Online Now
1 registered members (isaac), 403 guests, and 230 spiders.
Key: Admin, Global Mod, Mod
Member Spotlight
Mtier
Mtier
Germany, Mainz
Posts: 51
Joined: July 2006
Show All Member Profiles 
Forum Statistics
Forums35
Topics35,304
Posts192,608
Members11,857
Most Online1,872
Jul 23rd, 2019
Random Gallery Image
Latest Photos
The Sky
Land Rocks
Cozy Places
Trees
Powered by UBB.threads™ PHP Forum Software 7.7.2