Previous Thread
Next Thread
Print Thread
Hop To
#222367 02/14/2009 7:17 AM
Joined: Oct 2006
Posts: 37
G
newbie
newbie
G Offline
Joined: Oct 2006
Posts: 37
I've been having this trouble for awhile now. I have UBB.threads 7.4.2. Here's an example of what breaks it:

Quote
Quote
Quote
Quote
Post1
Post2
Post3
Post4


Joined: Aug 2006
Posts: 1,358
Y
Veteran
Veteran
Y Offline
Joined: Aug 2006
Posts: 1,358
Known problem for several versions (it was introduced in 7.3 where the ubb code handling was rewritten). Any ubb code nested 4 levels deep goes wrong.

I've kludged around the problem by embracing it smile I don't like quotes in quotes in quotes.

I made a mod that actually displays an error to the user if they "deepquote" too much.

https://www.ubbdev.com/forums/ubbthreads.php/topics/317183

Last edited by blaaskaak; 02/14/2009 7:31 AM.

[Linked Image from siemons.org]
Joined: Feb 2007
Posts: 1,294
Likes: 2
Veteran
Veteran
Joined: Feb 2007
Posts: 1,294
Likes: 2
Perhaps Rick can place your mod in the next release.

Joined: Aug 2006
Posts: 1,358
Y
Veteran
Veteran
Y Offline
Joined: Aug 2006
Posts: 1,358
Maybe, he could also just fix the problem with the nested tags.

I would still keep my mod because I don't like those deep nested quotes, but it would be wrong for forumsoftware to enforce it by default because of a fault of the tag processing code.


[Linked Image from siemons.org]
Joined: Oct 2006
Posts: 37
G
newbie
newbie
G Offline
Joined: Oct 2006
Posts: 37
I don't like deep quoting either, but 4 doesn't seem that deep to me.

Well, it sure is messy this way. It seems best to either fix it to work with deeper nesting or give an error. The end user shouldn't see the tags exposed. It makes it look like a bug.

Joined: Jun 2006
Posts: 9,242
Likes: 1
R
Former Developer
Former Developer
R Offline
Joined: Jun 2006
Posts: 9,242
Likes: 1
I shall have this fixed for 7.5 along with an admin option to specify the max number of quoted quotes.

Joined: Apr 2007
Posts: 3,940
Likes: 1
SD Offline
Former Developer
Former Developer
Joined: Apr 2007
Posts: 3,940
Likes: 1
there's a loop in bbcode.inc.php where you can manually up the limit from 3 to whatever you'd want..

PHP Code
	 foreach ($codes_to_parse as $code) {
			list($find, $replace) = $code;
			for ($i = 0; $i < 3; $i++) { 

that number 3 is the loop limit and although it applies to nested quotes, it really applies to anything nested period wink


Joined: Oct 2006
Posts: 37
G
newbie
newbie
G Offline
Joined: Oct 2006
Posts: 37
Cool, thanks!


Link Copied to Clipboard
ShoutChat
Comment Guidelines: Do post respectful and insightful comments. Don't flame, hate, spam.
Recent Topics
Bots
by Outdoorking - 04/13/2024 5:08 PM
Can you add html to language files?
by Baldeagle - 04/07/2024 2:41 PM
Do I need to rebuild my database?
by Baldeagle - 04/07/2024 2:58 AM
This is not a bug, but a suggestion
by Baldeagle - 04/05/2024 11:25 PM
Is UBB.threads still going?
by Aaron101 - 04/01/2022 8:18 AM
Who's Online Now
0 members (), 868 guests, and 467 robots.
Key: Admin, Global Mod, Mod
Random Gallery Image
Latest Gallery Images
Los Angeles
Los Angeles
by isaac, August 6
3D Creations
3D Creations
by JAISP, December 30
Artistic structures
Artistic structures
by isaac, August 29
Stones
Stones
by isaac, August 19
Powered by UBB.threads™ PHP Forum Software 8.0.0
(Preview build 20230217)